1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/ssh/ssh-auth.c ssh-conn.c ssh-internal.h ssh-trans.c src/ssh/test/

    From Deucе@VERT to Git commit to main/sbbs/master on Fri Mar 27 20:57:48 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/dc1ce31aedfba6301fe7adce
    Modified Files:
    src/ssh/ssh-auth.c ssh-conn.c ssh-internal.h ssh-trans.c src/ssh/test/test_arch.c
    Log Message:
    Add DSSH_GET_U32/DSSH_PUT_U32 internal macros, convert all ~130 call sites

    Unchecked big-endian uint32 read/write macros for internal library use (ssh-trans.c, ssh-auth.c, ssh-conn.c). Every call site individually
    audited: buffer size guards preserved where they were the sole protection, removed where already covered by prior bounds checks or exactly-sized allocations. Modules (kex/, key_algo/) continue using the public dssh_parse_uint32/dssh_serialize_uint32 functions.

    Eliminates 322 unreachable error-handling branches, raising overall branch coverage from 81.5% to 84.9%. Adds serialize_pos_past_bufsz test to
    bring ssh-arch.c back to 100% branch coverage.

    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net