https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1269

The only drawback is in Android chrome is does flash white for a second before it applies the css... Any thoughts on how to improve that?

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1271

I found a way to deal with the flashing css...but ftelnet is not playing nicely (its loading at the wrong size). So I'll have to keep working at it

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1273

Why just 'Dark Mode'? What if SysOp: 'Mamma Bear' wants a Hot Pink mode? :-P

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1274

Hot pink mode would contribute to the breakdown of western society

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1285

I'm on "vacation" right now, so I have very little time to review anything until next week.

Please avoid bundling whitespace changes in with unrelated requests. I can't tell at a glance if there are any functional changes to home.xjs or games.xjs.

Is checkbox.css and all of the related "checkbox" stuff just there to facilitate an "enable dark mode" checkbox? (Just curious.)

An option should be added to modopts.ini->[web] so that the sysop can decide whether they want to offer dark mode. This option should control whether the checkbox is shown and whether checkbox.css (or any other unnecessary-if-disabled) stuff is sent. (If you did this, great - I may have missed it.)

I see some inline styling added to index.xjs:

`.hidden { display:none; }`

I'd rather this kind of thing be in style.css unless it really needs to be inline (eg. to override something). Just an organizational consideration.

I have no problem with their being a default "dark mode"; the sysop can make the light and dark modes look however they want via custom.css. (We don't need to offer "hot pink mode" or anything else; that's up to the sysop to define - but light/dark makes sense.)

I'd like to make some changes eventually to how the user's preference is retained, possibly including time-of-day options, but leave that to me for later on as this ties into some other work.

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1286

Please avoid bundling whitespace changes in with unrelated requests. I can't tell at a glance if there are > any functional changes to home.xjs or games.xjs.

That is not whitespace change, that is putting those blocks into event handlers to delay the load of ftelnet until the html is unhidden. (And it is hidden until JS loads to avoid it flashing white each page load)

Is checkbox.css and all of the related "checkbox" stuff just there to facilitate an "enable dark mode" >checkbox? (Just curious.)

Correct. I may have been able to do a bit better with bootstrap 4 but since its bootstrap 3 I just went with this

An option should be added to modopts.ini->\[web\] so that the sysop can decide whether they want to offer dark mode. This option should control whether the checkbox is shown and whether checkbox.css (or any other unnecessary-if-disabled) stuff is sent. (If you did this, great - I may have missed it.)

Ok will add this

I see some inline styling added to index.xjs:
`.hidden { display:none; }`
I'd rather this kind of thing be in style.css unless it really needs to be inline (eg. to override something). Just an organizational consideration.

yes in this case I inlined it because I was it executed immediately and not wait for style.css to load. This helps avoid the screen flashing white before css is processed, when you are in dark mode

I have no problem with their being a default "dark mode"; the sysop can make the light and dark modes look however they want via custom.css. (We don't need to offer "hot pink mode" or anything else; that's up to the sysop to define - but light/dark makes sense.)

I briefly thought about theme support, but was more work than I wanted to do and really isn't something I see on the web much anyway except maybe office 365 and vbulletin

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/merge_requests/68#note_1383

@echicken waiting on your feedback/comments. its been working on my board now without any problems

i still sometimes see a white flash if a page is being extremely slow to load (some forum threads) but i doubt there is any way to really fix that

---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net